git-ents.gitmain
⌘K
foforge
commit a3fd3d9
cli: drop dead render_verdicts and unused facet-pretty dependency

render_verdicts had zero callers left; facet-pretty had zero call sites anywhere in the workspace. Removing both trims a whole dependency and the now-unused std::io::Write import it pulled in.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Joseph D. Carpinelli · 28 days ago

Reviews

No reviews of this commit yet — record a verdict below.

Start a review

verdict

Cargo.lock @@ -1909,7 +1909,6 @@ "ents-web", "facet", "facet-git-tree", - "facet-pretty", "figue", "gix", "gix-hash",
Cargo.toml @@ -73,7 +73,6 @@ cargo_metadata = "0.23" figue = "5.0.0-rc.5" facet = { version = "0.50.0-rc.0", features = ["reflect"] } -facet-pretty = "0.50.0-rc.5" getrandom = "0.4" facet-git-tree = { git = "https://github.com/git-ents/facet-git-tree" } form_urlencoded = "1"
crates/cli/git-ents/Cargo.toml @@ -23,7 +23,6 @@ ents-web = { workspace = true } facet = { workspace = true } facet-git-tree = { workspace = true } -facet-pretty = { workspace = true } figue = { workspace = true } gix = { workspace = true } gix-hash = { workspace = true }
crates/cli/git-ents/src/commands/mod.rs @@ -24,7 +24,6 @@ pub mod setup; pub mod toolchain; -use std::io::Write; use std::path::PathBuf; use gix_hash::ObjectId; @@ -106,18 +105,3 @@ hex } } - -/// Print `verdicts` (`gate.verdict-reason`) for a command that succeeded -/// under the advisory gate but still wants to surface a non-passing -/// verdict to the user, mirroring `sync.local-advisory`: a failing verdict -/// here is information, never a block. -pub fn render_verdicts( - out: &mut impl Write, - verdicts: &[(gix::refs::FullName, ents_gate::Verdict)], -) { - for (name, verdict) in verdicts { - if let ents_gate::Verdict::Fail(refusal) = verdict { - let _ = writeln!(out, "warning: {name}: {refusal}", name = name.as_bstr()); - } - } -}